Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
If you look at our CI logs, you'll see plenty of
fatal errormessages related to git. The root of the message is because thecheckoutstep of our CI does a shallow (0 history) checkout of the repo. When the git command is run with the commit sha, it cannot find the associate commit object and logs this error.Similarly, if the CLI is run outside of a git repo, git errors are also logged.
Turns out, this is because
execSyncdefaults stderr toinheritrather thanpipewhich is the default of stdout, stdin, and stdio for spawn functions.This PR explicitly sets this stdio to ignore stderr, stdin, and pipe stdout.
No test here since the only thing we could write would be "is called with the right stdio options." Which doesn't feel like a useful test anyway since those options aren't likely to change accidentally.