✨ Add basic parallel nonce support for GitHub actions#375
Merged
Conversation
wwilsman
suggested changes
Jun 18, 2021
fc91aaf to
3ce2685
Compare
This will at least get the happy path of parallel builds going. We'll need an advanced doc to highlight the issues with this (`GITHUB_RUN_ID` is not unique on rebuilds, which will cause Percy to fail)
3ce2685 to
ab61e82
Compare
wwilsman
suggested changes
Jun 18, 2021
Co-authored-by: Wil Wilsman <wil@percy.io>
samarsault
pushed a commit
that referenced
this pull request
Mar 3, 2023
Bumps @percy/sdk-utils from 1.0.0-beta.56 to 1.0.0-beta.58. --- updated-dependencies: - dependency-name: "@percy/sdk-utils" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This will at least get the happy path of parallel builds going. We'll need an advanced doc to highlight the issues with this (
GITHUB_RUN_IDis not unique on rebuilds, which will cause Percy to fail). Touches on #296, but doesn't completely solve it.