Skip to content

✨ Add basic parallel nonce support for GitHub actions#375

Merged
Robdel12 merged 2 commits intomasterfrom
rd/nonce-heroku-actions
Jun 18, 2021
Merged

✨ Add basic parallel nonce support for GitHub actions#375
Robdel12 merged 2 commits intomasterfrom
rd/nonce-heroku-actions

Conversation

@Robdel12
Copy link
Copy Markdown
Contributor

What is this?

This will at least get the happy path of parallel builds going. We'll need an advanced doc to highlight the issues with this (GITHUB_RUN_ID is not unique on rebuilds, which will cause Percy to fail). Touches on #296, but doesn't completely solve it.

@Robdel12 Robdel12 requested a review from wwilsman June 18, 2021 17:39
@Robdel12 Robdel12 force-pushed the rd/nonce-heroku-actions branch from fc91aaf to 3ce2685 Compare June 18, 2021 21:14
This will at least get the happy path of parallel builds going. We'll need an
advanced doc to highlight the issues with this (`GITHUB_RUN_ID` is not unique on
rebuilds, which will cause Percy to fail)
@Robdel12 Robdel12 force-pushed the rd/nonce-heroku-actions branch from 3ce2685 to ab61e82 Compare June 18, 2021 21:21
Co-authored-by: Wil Wilsman <wil@percy.io>
@Robdel12 Robdel12 requested a review from wwilsman June 18, 2021 22:10
Copy link
Copy Markdown
Contributor

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎮

@Robdel12 Robdel12 merged commit 94add97 into master Jun 18, 2021
@Robdel12 Robdel12 deleted the rd/nonce-heroku-actions branch June 18, 2021 22:16
@Robdel12 Robdel12 added the ✨ enhancement New feature or request label Jun 21, 2021
samarsault pushed a commit that referenced this pull request Mar 3, 2023
Bumps @percy/sdk-utils from 1.0.0-beta.56 to 1.0.0-beta.58.

---
updated-dependencies:
- dependency-name: "@percy/sdk-utils"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants