✨ Roll asset discovery browser to Chrome 92#371
Merged
Conversation
536f18a to
1469d60
Compare
Contributor
Author
|
@Robdel12 rebase |
1469d60 to
e816933
Compare
Contributor
|
Might need to increment the CI cache key |
afbf409 to
3aaf513
Compare
82ed6b6 to
8f83a42
Compare
f6f2479 to
bfa68db
Compare
bfa68db to
024fda0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This rolls the asset discovery browser used by
@percy/coreforward to Chrome 92 (from 87)Notes
This PR was originally for Chrome 91, but after a week of trying to debug/diagnose Windows issues with asset discovery in tests (and real life, likely), it made sense to move on and try a newer version. Chrome 92 passed all our tests on the first go, so we're going to roll forward with 92.