Skip to content

RFD site asciidoc fixes#46

Merged
benjaminleonard merged 13 commits into
masterfrom
rfd-site-asciidoc-fixes
Nov 14, 2023
Merged

RFD site asciidoc fixes#46
benjaminleonard merged 13 commits into
masterfrom
rfd-site-asciidoc-fixes

Conversation

@benjaminleonard

@benjaminleonard benjaminleonard commented Aug 22, 2023

Copy link
Copy Markdown
Collaborator

As I work through parity between react-asciidoc and the native renderer I am merging some of the fixes upstream here.

📦 Published PR as canary version: 1.2.5--canary.46.3e5514d.0

✨ Test out this PR locally via:

npm install @oxide/design-system@1.2.5--canary.46.3e5514d.0
# or 
yarn add @oxide/design-system@1.2.5--canary.46.3e5514d.0

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 360 files.

Valid Invalid Ignored Fixed
172 1 187 0
Click to see the invalid file list
  • components/src/asciidoc/Section.tsx

Comment thread components/src/asciidoc/Section.tsx
Comment thread components/src/asciidoc/Section.tsx
@benjaminleonard

Copy link
Copy Markdown
Collaborator Author

Hmm — including the Section here causes it to ignore (client side) the overrides I'm setting up in the RFD site. I'm guessing because this has it's own <Content> component that is untouched.

@benjaminleonard benjaminleonard merged commit 3e5514d into master Nov 14, 2023
@benjaminleonard benjaminleonard deleted the rfd-site-asciidoc-fixes branch November 14, 2023 19:35
@just-be-dev

Copy link
Copy Markdown
Contributor

🚀 PR was released in v1.2.5 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants