Stages.ByName/ByTarget/ThroughTarget: accept numbers#275
Merged
rhatdan merged 1 commit intoopenshift:masterfrom Jan 12, 2024
Merged
Stages.ByName/ByTarget/ThroughTarget: accept numbers#275rhatdan merged 1 commit intoopenshift:masterfrom
rhatdan merged 1 commit intoopenshift:masterfrom
Conversation
Accept integer values in ByName(), ByTarget(), and ThroughTarget() as aliases for the stages with that "Position" value. Add a ByPosition() alongside ByName(). It would be faster to just index the stages directly instead of searching for a stage with the right Position value, but this lets us avoid a bounds check and is just easier to explain. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Contributor
|
@nalind: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
LGTM |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept integer values in ByName(), ByTarget(), and ThroughTarget() as aliases for the stages with that "Position" value. Add a ByPosition() alongside ByName().
It would be faster to just index the stages directly instead of searching for a stage with the right Position value, but this lets us avoid a bounds check and is just easier to explain.
Fixes #274.