fix(azure): refresh auth token during retries#1533
Merged
RobertCraigie merged 1 commit intonextfrom Jul 9, 2024
Merged
Conversation
Collaborator
Author
|
cc @kristapratico, I can't seem to request a review |
1 task
kristapratico
approved these changes
Jul 9, 2024
Contributor
kristapratico
left a comment
There was a problem hiding this comment.
This is a better strategy, thanks @RobertCraigie! I've verified the change on my end and all looks good 👍
e5341d7 to
ef58b3f
Compare
Merged
megamanics
pushed a commit
to devops-testbed/openai-python
that referenced
this pull request
Aug 14, 2024
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #1531
This builds on Krista's PR & restructures the fix slightly so that we only refresh the token if the
Authorizationheader wasn't explicitly given by the user.Additional context & links
#1526