chore: expand pull request template with action items#2509
Conversation
|
It might make sense to incorporate the hidden/commented messages in this PR somehow? |
Codecov Report
@@ Coverage Diff @@
## main #2509 +/- ##
==========================================
- Coverage 93.06% 93.05% -0.01%
==========================================
Files 132 139 +7
Lines 4856 5172 +316
Branches 1040 1110 +70
==========================================
+ Hits 4519 4813 +294
- Misses 337 359 +22
|
|
The commented lines only show up to the person who is authoring the PR. They are hidden if the PR author leaves it it when they click submit. |
rauno56
left a comment
There was a problem hiding this comment.
Yep, if any, those instructions could be hidden comments, because they don't add much for the reader.
What I've personally found, is that the checklists are useful in only occasionally(which IMHO talks for them - such a simple means for some benefit). I hope people just take those as reminders and nothing to religiously follow. If we really have a strong rule, we should be able to automate enforcing it as "following guidelines" is enforced by the linter.
Co-authored-by: Rauno Viskus <Rauno56@users.noreply.github.com>
Which problem is this PR solving?