feat(@opentelemetry-instrumentation-fetch): support reading response body from the hook applyCustomAttributesOnSpan#2497
Merged
vmarchaud merged 2 commits intoopen-telemetry:mainfrom Oct 9, 2021
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2497 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 137 137
Lines 5043 5044 +1
Branches 1067 1067
=======================================
+ Hits 4702 4703 +1
Misses 341 341
|
Member
|
Hi! Thanks for contributing! Could you first provide a unit test showing the problem (i.e., one that fails without your code changes and passes with them)? |
6f57be3 to
3fe7175
Compare
…body from the hook applyCustomAttributesOnSpan
3fe7175 to
7f90bf4
Compare
Contributor
Author
done~~ |
dyladan
approved these changes
Sep 28, 2021
vmarchaud
approved these changes
Oct 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opentelemetry-instrumentation-fetch support reading response body from the hook applyCustomAttributesOnSpan
Which problem is this PR solving?
applyCustomAttributesOnSpan's callback param response has been used, so that we can't get response body.
https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch
UT with current code:
Detail error is as follows,
Short description of the changes