Skip to content

fix(sdk-metrics-base): metrics name should be in the max length of 63#2495

Merged
vmarchaud merged 5 commits intoopen-telemetry:mainfrom
legendecas:metrics-ff/metric-name
Oct 10, 2021
Merged

fix(sdk-metrics-base): metrics name should be in the max length of 63#2495
vmarchaud merged 5 commits intoopen-telemetry:mainfrom
legendecas:metrics-ff/metric-name

Conversation

@legendecas
Copy link
Copy Markdown
Member

@legendecas legendecas commented Sep 24, 2021

Which problem is this PR solving?

@legendecas legendecas requested a review from a team September 24, 2021 03:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 24, 2021 •
edited
Loading

Codecov Report

Merging #2495 (a06c9ae) into main (faca317) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2495      +/-   ##
==========================================
+ Coverage   92.89%   93.23%   +0.34%     
==========================================
  Files         127      137      +10     
  Lines        4376     5044     +668     
  Branches      930     1067     +137     
==========================================
+ Hits         4065     4703     +638     
- Misses        311      341      +30
Impacted Files Coverage Δ
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
...kages/opentelemetry-exporter-otlp-http/src/util.ts 100.00% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.58% <0.00%> (ø)
.../opentelemetry-exporter-otlp-http/src/transform.ts 88.69% <0.00%> (ø)
...lemetry-exporter-otlp-http/src/transformMetrics.ts 95.71% <0.00%> (ø)
...lemetry-exporter-otlp-http/src/OTLPExporterBase.ts 92.15% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.98% <0.00%> (ø)
...ages/opentelemetry-exporter-otlp-http/src/types.ts 100.00% <0.00%> (ø)

obecny
obecny reviewed Sep 24, 2021
View reviewed changes
Comment thread experimental/packages/opentelemetry-sdk-metrics-base/test/Meter.test.ts Outdated
@vmarchaud vmarchaud requested a review from obecny October 9, 2021 13:58
@vmarchaud vmarchaud merged commit ed0ba06 into open-telemetry:main Oct 10, 2021
@vmarchaud vmarchaud added the bug Something isn't working label Oct 10, 2021
@legendecas legendecas deleted the metrics-ff/metric-name branch October 12, 2021 03:07
@dyladan dyladan mentioned this pull request Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obecny obecny Awaiting requested review from obecny

4 more reviewers

@weyert weyert weyert approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@Flarna Flarna Flarna approved these changes

@naseemkullah naseemkullah naseemkullah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@legendecas @weyert @obecny @vmarchaud @Flarna @naseemkullah