chore: remove getting started and link to documentation.#2493
Merged
vmarchaud merged 3 commits intoopen-telemetry:mainfrom Oct 17, 2021
svrnm:remove-old-getting-started
Merged
chore: remove getting started and link to documentation.#2493vmarchaud merged 3 commits intoopen-telemetry:mainfrom svrnm:remove-old-getting-started
vmarchaud merged 3 commits intoopen-telemetry:mainfrom
svrnm:remove-old-getting-started
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2493 +/- ##
=======================================
Coverage 93.05% 93.05%
=======================================
Files 139 139
Lines 5172 5172
Branches 1110 1110
=======================================
Hits 4813 4813
Misses 359 359 |
Member
|
Would you like to rebase this, @svrnm? |
Member
Author
|
@rauno56 done. |
rauno56
approved these changes
Oct 14, 2021
Member
rauno56
left a comment
There was a problem hiding this comment.
I assume the guide(or equivalent info) moved to the website repo, right?
Member
Author
|
Yes exactly. The docs on the website now contain similar information (not exactly the same) |
vmarchaud
approved these changes
Oct 17, 2021
This was referenced Nov 9, 2021
MannyPamintuanWorkAccount
added a commit
to MannyPamintuanWorkAccount/federation
that referenced
this pull request
Dec 13, 2021
This PR does the following, Updates the link to "Getting Started" to the [most recent link provided in the OTel-JS Repo](https://github.com/open-telemetry/opentelemetry-js/blob/main/README.md?plain=1#L5) This change in linking is documented in OTel-JS [commit apollographql#2493](open-telemetry/opentelemetry-js#2493)
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Dec 13, 2021
To reflect the change of location [upstream] [upstream]: open-telemetry/opentelemetry-js#2493
MannyPamintuanWorkAccount
added a commit
to MannyPamintuanWorkAccount/federation
that referenced
this pull request
Dec 13, 2021
Per @abernix's [great suggestion](apollographql#1302 (review)), this PR does the following, - Updates the link to "Getting Started" to the [most recent link provided in the OTel-JS Repo](https://github.com/open-telemetry/opentelemetry-js/blob/main/README.md?plain=1#L5) - This change in linking is documented in OTel-JS [commit apollographql#2493](open-telemetry/opentelemetry-js#2493)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
As per the SIG discussion yesterday this PR removes the old getting started guide and links to the official documentation at https://opentelemetry.io/docs/js/getting_started/
Short description of the changes
Note, if you grep for "getting-started", there are a few more references, they all point to a jaeger getting started.