chore: Fix lint warnings in propagator-jaeger, propagator-b3, resources, and sdk-metrics-base packages#2406
Merged
vmarchaud merged 6 commits intoopen-telemetry:mainfrom Aug 14, 2021
Conversation
alisabzevari
commented
Aug 9, 2021
| } | ||
|
|
||
| export function parseHeader(header: unknown) { | ||
| function parseHeader(header: unknown) { |
Contributor
Author
There was a problem hiding this comment.
I removed export by intuition. Let me know if I did wrong here.
Member
There was a problem hiding this comment.
If the tests pass it's probably fine. It might have been exported for those
e4357c1 to
2439b24
Compare
Codecov Report
@@ Coverage Diff @@
## main #2406 +/- ##
==========================================
- Coverage 92.64% 92.62% -0.03%
==========================================
Files 137 137
Lines 4975 4975
Branches 1048 1048
==========================================
- Hits 4609 4608 -1
- Misses 366 367 +1
|
dyladan
approved these changes
Aug 9, 2021
MSNev
approved these changes
Aug 10, 2021
vmarchaud
approved these changes
Aug 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
propagator-jaeger,propagator-b3,resources, andsdk-metrics-basepackages (related to Fix lint warnings #1093)Short description of the changes