[chore]: enable negative-positive rule from testifylint#5849
Merged
pellared merged 1 commit intoopen-telemetry:mainfrom Sep 30, 2024
Merged
[chore]: enable negative-positive rule from testifylint#5849pellared merged 1 commit intoopen-telemetry:mainfrom
pellared merged 1 commit intoopen-telemetry:mainfrom
Conversation
dmathieu
approved these changes
Sep 26, 2024
pellared
requested changes
Sep 27, 2024
Member
pellared
left a comment
There was a problem hiding this comment.
It looks like assert.Equal is correct in almost all places (except one).
Contributor
Author
|
I believ it's probably better to keep float-compare disabled in that case. |
Member
I agree. However, you can keep the |
d851ce9 to
93c0832
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5849 +/- ##
=====================================
Coverage 84.5% 84.5%
=====================================
Files 272 272
Lines 22734 22734
=====================================
+ Hits 19225 19226 +1
+ Misses 3166 3165 -1
Partials 343 343 |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
93c0832 to
21adde1
Compare
pellared
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testifylint is a linter that provides best practices with the use of testify.
This PR enables negative-positive rule from testifylint