Skip to content

Add an option to configure the exporter buffer of the BatchProcessor#5877

Merged
MrAlias merged 6 commits intoopen-telemetry:mainfrom
Frapschen:add-WithExportBufferSize
Oct 10, 2024
Merged

Add an option to configure the exporter buffer of the BatchProcessor#5877
MrAlias merged 6 commits intoopen-telemetry:mainfrom
Frapschen:add-WithExportBufferSize

Conversation

@Frapschen
Copy link
Copy Markdown
Contributor

resolve: #5238

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.5%. Comparing base (eb9279b) to head (b51acf0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5877   +/-   ##
=====================================
  Coverage   84.5%   84.5%           
=====================================
  Files        272     272           
  Lines      22816   22824    +8     
=====================================
+ Hits       19287   19296    +9     
+ Misses      3180    3179    -1     
  Partials     349     349           

see 2 files with indirect coverage changes

Comment thread sdk/log/batch.go Outdated
@Frapschen Frapschen requested a review from MrAlias October 8, 2024 09:57
@Frapschen Frapschen force-pushed the add-WithExportBufferSize branch from 5eab741 to 9d886c5 Compare October 8, 2024 10:01
Comment thread sdk/log/batch.go Outdated
Comment thread sdk/log/batch.go Outdated
Comment thread sdk/log/batch.go Outdated
@Frapschen Frapschen requested a review from MrAlias October 8, 2024 15:05
@Frapschen Frapschen force-pushed the add-WithExportBufferSize branch from 46f2b2c to 17847ff Compare October 9, 2024 01:32
Copy link
Copy Markdown
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comments.

Comment thread sdk/log/batch.go Outdated
Comment thread sdk/log/batch.go Outdated
Co-authored-by: Damien Mathieu <42@dmathieu.com>
@Frapschen Frapschen requested a review from dmathieu October 10, 2024 02:09
@MrAlias MrAlias merged commit a7d5c1a into open-telemetry:main Oct 10, 2024
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
dashpole added a commit that referenced this pull request Oct 11, 2024
### Added

- Add `go.opentelemetry.io/otel/sdk/metric/exemplar` package which
includes `Exemplar`, `Filter`, `TraceBasedFilter`, `AlwaysOnFilter`,
`HistogramReservoir`, `FixedSizeReservoir`, `Reservoir`, `Value` and
`ValueType` types. These will be used for configuring the exemplar
reservoir for the metrics sdk. (#5747, #5862)
- Add `WithExportBufferSize` option to log batch processor.(#5877)

### Changed

- Enable exemplars by default in `go.opentelemetry.io/otel/sdk/metric`.
Exemplars can be disabled by setting
`OTEL_METRICS_EXEMPLAR_FILTER=always_off` (#5778)
- `Logger.Enabled` in `go.opentelemetry.io/otel/log` now accepts a newly
introduced `EnabledParameters` type instead of `Record`. (#5791)
- `FilterProcessor.Enabled` in
`go.opentelemetry.io/otel/sdk/log/internal/x` now accepts
`EnabledParameters` instead of `Record`. (#5791)
- The `Record` type in `go.opentelemetry.io/otel/log` is no longer
comparable. (#5847)
- Performance improvements for the trace SDK `SetAttributes` method in
`Span`. (#5864)
- Reduce memory allocations for the `Event` and `Link` lists in `Span`.
(#5858)
- Performance improvements for the trace SDK `AddEvent`, `AddLink`,
`RecordError` and `End` methods in `Span`. (#5874)

### Deprecated

- Deprecate all examples under `go.opentelemetry.io/otel/example` as
they are moved to [Contrib
repository](https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/examples).
(#5854)

### Fixed

- The race condition for multiple `FixedSize` exemplar reservoirs
identified in #5814 is resolved. (#5819)
- Fix log records duplication in case of heterogeneous resource
attributes by correctly mapping each log record to it's resource and
scope. (#5803)
- Fix timer channel drain to avoid hanging on Go 1.23. (#5868)
- Fix delegation for global meter providers, and panic when calling
otel.SetMeterProvider. (#5827)
- Change the `reflect.TypeOf` to use a nil pointer to not allocate on
the heap unless necessary. (#5827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option to configure the exporter buffer of the BatchProcessor

3 participants