fix(e2e): improve types for fetch and mockLogger

danielroe · danielroe · commit eb40a6a65948 · 2024-04-15T17:18:55.000+02:00
diff --git a/src/core/mock.ts b/src/core/mock.ts
@@ -1,16 +1,17 @@
 import { consola } from 'consola'
+import type { LogType } from 'consola'
 import { useTestContext } from './context'
 
 export function mockFn () {
   const ctx = useTestContext()
   return ctx.mockFn
 }
 
-export function mockLogger (): Record<string, Function> {
-  const mocks: any = {}
+export function mockLogger (): Record<LogType, (...args: any[]) => void> {
+  const mocks: Partial<Record<LogType, (...args: any[]) => void>> = {}
   consola.mockTypes((type) => {
     mocks[type] = mockFn()
-    return mocks[type]
+    return mocks[type]!
   })
-  return mocks
+  return mocks as Record<LogType, (...args: any[]) => void>
 }
diff --git a/src/core/server.ts b/src/core/server.ts
@@ -73,7 +73,7 @@ export async function stopServer () {
   }
 }
 
-export function fetch (path: string, options?: any) {
+export function fetch (path: string, options?: RequestInit) {
   return _fetch(url(path), options)
 }
 
diff --git a/src/core/types.ts b/src/core/types.ts
@@ -32,7 +32,7 @@ export interface TestContext {
   browser?: Browser
   url?: string
   serverProcess?: ExecaChildProcess
-  mockFn?: Function
+  mockFn?: (...args: any[]) => unknown
   /**
    * Functions to run on the vitest `afterAll` hook.
    * Useful for removing anything created during the test.

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ export async function stopServer () {`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`
`76`		`-export function fetch (path: string, options?: any) {`
	`76`	`+export function fetch (path: string, options?: RequestInit) {`
`77`	`77`	`return _fetch(url(path), options)`
`78`	`78`	`}`
`79`	`79`