Skip to content

fix(utils): Router config trailingSlash causes error with dynamic nuxt-child routes#9505

Merged
pi0 merged 3 commits intonuxt:devfrom
ms-fadaei:fix/trailing-slash-with-dynamic-child
Jul 1, 2021
Merged

fix(utils): Router config trailingSlash causes error with dynamic nuxt-child routes#9505
pi0 merged 3 commits intonuxt:devfrom
ms-fadaei:fix/trailing-slash-with-dynamic-child

Conversation

@ms-fadaei
Copy link
Copy Markdown
Contributor

@ms-fadaei ms-fadaei commented Jul 1, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

fix #9472
This bug existed because trailingSlash = true not been considered in a specific condition and exists regex missed it!

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #9505 (267373f) into dev (eb6bd9f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #9505      +/-   ##
==========================================
- Coverage   65.15%   65.12%   -0.04%     
==========================================
  Files          94       94              
  Lines        4107     4109       +2     
  Branches     1125     1126       +1     
==========================================
  Hits         2676     2676              
- Misses       1153     1154       +1     
- Partials      278      279       +1
Flag Coverage Δ
unittests 65.12% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/route.js 85.18% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6bd9f...267373f. Read the comment docs.

clarkdo
clarkdo reviewed Jul 1, 2021
View reviewed changes
Comment thread packages/utils/src/route.js Outdated
pi0
pi0 reviewed Jul 1, 2021
View reviewed changes
Comment thread packages/utils/src/route.js
@ms-fadaei ms-fadaei requested a review from pi0 July 1, 2021 12:51
pi0
pi0 reviewed Jul 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! <3

@pi0 pi0 merged commit 20f481f into nuxt:dev Jul 1, 2021
@pi0 pi0 mentioned this pull request Aug 11, 2021
Closed
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
Closed
@danielroe danielroe mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 left review comments

+1 more reviewer

@clarkdo clarkdo clarkdo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Router config trailingSlash causes error with dynamic nuxt-child routes

5 participants

@ms-fadaei @codecov-commenter @clarkdo @pi0 @danielroe