Conversation
atinux
left a comment
There was a problem hiding this comment.
Looks good to me, will need a second eye on this from @danielroe
danielroe
left a comment
There was a problem hiding this comment.
This looks good to me - nice changes.
The one question I have is about the comment on https://github.com/nuxt/nuxt.js/blob/0742f59e2478bd3998fd4d49b6200584ee5e2721/packages/vue-app/template/utils.js#L61 but if you're happy with this @atinux then I am too.
|
I think it's fine to reload the templates when we do a full refresh on preview mode. @pi0 do you want to take a look at it or happy to merge and let people use it with nuxt-edge? |
pi0
left a comment
There was a problem hiding this comment.
Generally looks good to me. We are introducing a behavior change that but it makes lifecycle more explicit can only slightly affect performance in cases usage was depending on the parallel run.
|
Looks good to me. Pending for #10510 before merging new PRs. |
Codecov Report
@@ Coverage Diff @@
## dev #10489 +/- ##
=======================================
Coverage 65.15% 65.15%
=======================================
Files 94 94
Lines 4155 4155
Branches 1172 1172
=======================================
Hits 2707 2707
Misses 1169 1169
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Types of changes
Description
Changes:
1. Make sure all
fetchhooks get called properly in preview modePrior to this change, if a page component contained a
fetchhook, all underlying componentfetchhooks would not be called in preview mode. In addition to that, if a component contained afetchhook and sub components of the component also contained afetchhook, only the root componentfetchhook would be called in preview mode.2. Make sure that potential
asyncDataand oldfetchhooks resolve prior to any newfetchhook calls in preview mode in accordance with the Nuxt lifecycle diagramPrior to this change, if you dynamically rendered components based on data from the
asyncDatahook, and the dynamically rendered components contained afetchhook, thosefetchhooks would not be called, becauseasyncData, oldfetch, and newfetchwere all resolving in parallel in preview mode.Resolves:
Checklist: