fix(nuxt): move app augments to core nuxt types#27900
Merged
Conversation
|
|
Merged
danielroe
added a commit
that referenced
this pull request
Jun 28, 2024
danielroe
added a commit
that referenced
this pull request
Jun 29, 2024
Kamsou
pushed a commit
to Kamsou/nuxt
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
Now that we are not explicitly importing from
#appindex it's possible for these augments to disappear mysteriously for a user. By adding them to corenuxttypes we avoid that danger.Note: we will probably move them again later - we'd like to separate the 'type namespaces' for nuxt configuration + runtime, but for now this is a good location.