chore: add extra types for empty array definitions

danielroe · danielroe · commit 02945b9fa6d7 · 2024-06-13T22:54:50.000+01:00
diff --git a/packages/nuxt/src/app/components/nuxt-island.ts b/packages/nuxt/src/app/components/nuxt-island.ts
@@ -1,4 +1,4 @@
-import type { Component, PropType } from 'vue'
+import type { Component, PropType, VNode } from 'vue'
 import { Fragment, Teleport, computed, createStaticVNode, createVNode, defineComponent, getCurrentInstance, h, nextTick, onMounted, ref, toRaw, watch, withMemo } from 'vue'
 import { debounce } from 'perfect-debounce'
 import { hash } from 'ohash'
@@ -29,7 +29,7 @@ const getId = import.meta.client ? () => (id++).toString() : randomUUID
 const components = import.meta.client ? new Map<string, Component>() : undefined
 
 async function loadComponents (source = appBaseURL, paths: NuxtIslandResponse['components']) {
-  const promises = []
+  const promises: Array<Promise<void>> = []
 
   for (const component in paths) {
     if (!(components!.has(component))) {
@@ -259,7 +259,7 @@ export default defineComponent({
 
         // should away be triggered ONE tick after re-rendering the static node
         withMemo([teleportKey.value], () => {
-          const teleports = []
+          const teleports: Array<VNode> = []
           // this is used to force trigger Teleport when vue makes the diff between old and new node
           const isKeyOdd = teleportKey.value === 0 || !!(teleportKey.value && !(teleportKey.value % 2))
 
diff --git a/packages/nuxt/src/app/components/utils.ts b/packages/nuxt/src/app/components/utils.ts
@@ -86,7 +86,7 @@ export function vforToArray (source: any): any[] {
     if (import.meta.dev && !Number.isInteger(source)) {
       console.warn(`The v-for range expect an integer value but got ${source}.`)
     }
-    const array = []
+    const array: number[] = []
     for (let i = 0; i < source; i++) {
       array[i] = i
     }
diff --git a/packages/nuxt/src/core/nuxt.ts b/packages/nuxt/src/core/nuxt.ts
@@ -698,7 +698,7 @@ const RESTART_RE = /^(?:app|error|app\.config)\.(?:js|ts|mjs|jsx|tsx|vue)$/i
 function deduplicateArray<T = unknown> (maybeArray: T): T {
   if (!Array.isArray(maybeArray)) { return maybeArray }
 
-  const fresh = []
+  const fresh: any[] = []
   const hashes = new Set<string>()
   for (const item of maybeArray) {
     const _hash = hash(item)
diff --git a/packages/nuxt/src/core/runtime/nitro/renderer.ts b/packages/nuxt/src/core/runtime/nitro/renderer.ts
@@ -400,7 +400,7 @@ export default defineRenderHandler(async (event): Promise<Partial<RenderResponse
   // 2. Styles
   head.push({ style: inlinedStyles })
   if (!isRenderingIsland || import.meta.dev) {
-    const link = []
+    const link: Link[] = []
     for (const style in styles) {
       const resource = styles[style]
       // Do not add links to resources that are inlined (vite v5+)
diff --git a/packages/nuxt/src/pages/utils.ts b/packages/nuxt/src/pages/utils.ts
@@ -232,7 +232,7 @@ export async function getRouteMeta (contents: string, absolutePath: string): Pro
         }
 
         if (property.value.type === 'ArrayExpression') {
-          const values = []
+          const values: string[] = []
           for (const element of property.value.elements) {
             if (!element) {
               continue

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ export function vforToArray (source: any): any[] {`
`86`	`86`	`if (import.meta.dev && !Number.isInteger(source)) {`
`87`	`87`	console.warn(`The v-for range expect an integer value but got ${source}.`)
`88`	`88`	`}`
`89`		`- const array = []`
	`89`	`+ const array: number[] = []`
`90`	`90`	`for (let i = 0; i < source; i++) {`
`91`	`91`	`array[i] = i`
`92`	`92`	`}`
Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ export async function getRouteMeta (contents: string, absolutePath: string): Pro`
`232`	`232`	`}`
`233`	`233`
`234`	`234`	`if (property.value.type === 'ArrayExpression') {`
`235`		`- const values = []`
	`235`	`+ const values: string[] = []`
`236`	`236`	`for (const element of property.value.elements) {`
`237`	`237`	`if (!element) {`
`238`	`238`	`continue`