BUG: Fix reduction return NULL to be goto fail#24037
Merged
charris merged 1 commit intonumpy:maintenance/1.25.xfrom Jun 24, 2023
Merged
BUG: Fix reduction return NULL to be goto fail#24037charris merged 1 commit intonumpy:maintenance/1.25.xfrom
return NULL to be goto fail#24037charris merged 1 commit intonumpy:maintenance/1.25.xfrom
Conversation
This should clearly have been a cleanup. Closes numpygh-24003
Member
Author
|
The test failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24004.
This should clearly have been a cleanup.
Closes gh-24003
I think the following failure I mentioned is just valgrind late detecting some indirect losses with a delay for whatever reason, since it shouldn't even alloc an iterator.