TST, MAINT: Replace most setup with setup_method (also teardown)#22489
Merged
charris merged 6 commits intonumpy:maintenance/1.23.xfrom Oct 28, 2022
Merged
TST, MAINT: Replace most setup with setup_method (also teardown)#22489charris merged 6 commits intonumpy:maintenance/1.23.xfrom
charris merged 6 commits intonumpy:maintenance/1.23.xfrom
Conversation
Not actually sure that setup_module() is what was wanted here, but it works? Mention a bit more about actual pytest fixtures.
In some cases, the replacement is clearly not what is intended, in those (where setup was called explicitly), I mostly renamed `setup` to `_setup`. The `test_ccompile_opt` is a bit confusing, so left it right now (this will probably fail)
Not new things, but in touched lines...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22487.
In some cases, the replacement is clearly not what is intended,
in those (where setup was called explicitly), I mostly renamed
setupto_setup.The
test_ccompile_optis a bit confusing, so left it right now(this will probably fail)
Also changed the docs a little bit. (Draft, just because I expect one failure still.)
Closes gh-22486