Skip to content

BUG: Restore vc141 support#20714

Merged
charris merged 1 commit intonumpy:maintenance/1.22.xfrom
charris:backport-20712
Jan 3, 2022
Merged

BUG: Restore vc141 support#20714
charris merged 1 commit intonumpy:maintenance/1.22.xfrom
charris:backport-20712

Conversation

@charris
Copy link
Copy Markdown
Member

@charris charris commented Jan 3, 2022

Backport of #20712.

__popcnt needs intrin.h, but it was only being included implicitly by a long chain of
system headers on VS2019. Header files on VS2017 is slightly different and intrin.h was
not included implicitly. Headers that are used should be implicitly included.

@charris charris added this to the 1.22.1 release milestone Jan 3, 2022
@charris charris merged commit f9d73fe into numpy:maintenance/1.22.x Jan 3, 2022
@charris charris deleted the backport-20712 branch January 3, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants