BUG: Force `npymath to respect npy_longdouble`#20465
Merged
charris merged 1 commit intonumpy:maintenance/1.21.xfrom Nov 26, 2021
Merged
BUG: Force `npymath to respect npy_longdouble`#20465charris merged 1 commit intonumpy:maintenance/1.21.xfrom
npymath to respect npy_longdouble`#20465charris merged 1 commit intonumpy:maintenance/1.21.xfrom
Conversation
…t `npy_longdouble` (numpy#20360) In some certain cases mostly workarounds, there's a necessity to define `npy_longdouble` as `double` even if that was against the compiler implementation(sizeof(long double) != sizeof(double)). Therefore, avoid `long double`, use `npy_longdouble` instead, and when it comes to standard math functions make sure of using the double version when `NPY_SIZEOF_LONGDOUBLE` == `NPY_SIZEOF_DOUBLE`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #20360.
Revert from long double changes and force
npymathto respectnpy_longdouble.In some certain cases mostly workarounds, there's a necessity to define
npy_longdoubleas
doubleeven if that was against the compiler implementation(sizeof(long double) != sizeof(double)).Therefore, avoid
long double, usenpy_longdoubleinstead,and when it comes to standard math functions make sure of using
the double version when
NPY_SIZEOF_LONGDOUBLE==NPY_SIZEOF_DOUBLE.Closes #20348