Merged
Conversation
Member
|
Is there any use for |
Member
Author
There are a few In [11]: import numpy as np
In [12]: finfo_f8 = np.finfo(np.float64)
...: machar_f8 = np.MachAr(np.float64)
In [14]: set(dir(machar_f8)) - set(dir(finfo_f8))
Out[14]:
{'_do_init',
'_str_xmax',
'_str_xmin',
'epsilon',
'huge',
'ibeta',
'irnd',
'it',
'ngrd',
'title',
'xmax',
'xmin'} |
Member
|
Hmm, fair point. On some of these, I would be willing to just gamble that nobody uses them anyway, i.e. |
Member
Author
|
Ah well, let's give deprecating |
Member
|
Thanks Bas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
np.MachArclass, the matchingnp.core.macharmodule andnp.finfo.macharattribute.As an alternative it is recommended to use to directly grab the property of interest from the
np.finfoinstance.Note that the module is technically private, but with the lack of underscores it's better to be safe than sorry.