ENH: Add missing parameters to the nan<x> functions#20027
Merged
charris merged 6 commits intonumpy:mainfrom Oct 4, 2021
Merged
ENH: Add missing parameters to the nan<x> functions#20027charris merged 6 commits intonumpy:mainfrom
nan<x> functions#20027charris merged 6 commits intonumpy:mainfrom
Conversation
added 6 commits
October 4, 2021 19:04
…d counterparts * nanmin: initial & where * nanmax: initial & where * nanargmin: keepdims & out * nanargmax: keepdims & out * nansum: initial & where * nanprod: initial & where * nanmean: where * nanvar: where * nanstd: where
BvB93
commented
Oct 4, 2021
Comment on lines
+1147
to
+1148
| .. versionadded:: 1.22.0 | ||
|
|
Member
Author
There was a problem hiding this comment.
Not directly related to this PR, but I noticed #19211 didn't add a versionadded directive.
Member
|
Thanks Bas. I was a bit worried about the functions that used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20024
A number of the
nan<x>functions previously lacked parameters that werepresent in their<x>-based counterpart,e.g. the
whereparameter was present innp.meanbut absent fromnp.nanmean.This PR thus ports the following (previously missing) parameters to the
nan<x>functions:initial&whereinitial&wherekeepdims&outkeepdims&outinitial&whereinitial&wherewherewherewhere