BLD, SIMD: Fix testing extra checks when -Werror isn't applicable for Clang
#19656
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or Clang. In certain cases `-Werror` gets skipped during the availability test due to "unused arguments" warnings. To solve the issue, `-Werror-implicit-function-declaration` was added as a secondary flag, which is enough to guarantee the sanity of the testing process when it comes to testing the availability of certain intrinsics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #19642.
In certain cases
-Werrorgets skipped during the availability test dueto "unused arguments" warnings. To solve the issue,
-Werror-implicit-function-declarationwas added as a secondary flag, which is enough to guarantee the sanity of the testing process
when it comes to testing the availability of certain intrinsics.
closes #19624