DEP: Disable PyUFunc_GenericFunction and PyUFunc_SetUsesArraysAsData #18697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both functions have been deprecated in 1.19.x without complaints (so far). The first function is largely identical to a Python ufunc call. The second function had served internal NumPy purposes until NumPy 1.6 (probably), and since then had a comment that it should probably be removed (it was not documented).
6d12ecd to
a115369
Compare
mattip
approved these changes
Mar 30, 2021
Member
mattip
left a comment
There was a problem hiding this comment.
LGTM. It seems there are no tests for this function and its deprecation.
Member
Author
|
🤷 I can add a small test that it raises if you like. These functions where never tested, and unused for probably around a decade... |
Member
|
Thanks @seberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both functions have been deprecated in 1.19.x without complaints
(so far). The first function is largely identical to a Python ufunc
call. The second function had served internal NumPy purposes until
NumPy 1.6 (probably), and since then had a comment that it should
probably be removed (it was not documented).