fix(nx-dev): plugin-registry menu#26767
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e0d6fef. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
isaacplmann
left a comment
There was a problem hiding this comment.
I don't think it looks good to have a sidebar menu on that page. You're just repeating the extending Nx menu. If you want the plugins to be combined with extending Nx, then we should actually combine the two sections and come up with a design for that.
|
I realize now that you're trying add the top menu on mobile. You succeeded at that, but also added a sidebar on desktop - that shouldn't be there. |
Ohh...yeah now I understand...that component needs refactoring. I'll fix that. |
e0e818e to
e0d6fef
Compare
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> When on https://nx.dev/plugin-registry the side-bar menu doesn't open on mobile. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Should obviously open. Also adjusted the top-level header menu "Documentation" -> "Docs" (just sounds better) ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 6ce107d)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
When on https://nx.dev/plugin-registry the side-bar menu doesn't open on mobile.
Expected Behavior
Should obviously open. Also adjusted the top-level header menu "Documentation" -> "Docs" (just sounds better)
Related Issue(s)
Fixes #