Skip to content

feat(linter): support eslint.config.cjs and *.cjs extension with flat config#26637

Merged
AgentEnder merged 2 commits intonrwl:masterfrom
benpsnyder:feat/support-cjs-flat-config-eslint
Jul 8, 2024
Merged

feat(linter): support eslint.config.cjs and *.cjs extension with flat config#26637
AgentEnder merged 2 commits intonrwl:masterfrom
benpsnyder:feat/support-cjs-flat-config-eslint

Conversation

@benpsnyder
Copy link
Copy Markdown
Contributor

@benpsnyder benpsnyder commented Jun 22, 2024

Fixes #26636

@benpsnyder benpsnyder requested a review from a team as a code owner June 22, 2024 18:23
@benpsnyder benpsnyder requested a review from meeroslav June 22, 2024 18:23
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2024 0:47am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jun 22, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5597a76. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@benpsnyder benpsnyder force-pushed the feat/support-cjs-flat-config-eslint branch 2 times, most recently from 65edf38 to d9480e0 Compare June 22, 2024 19:16
@benpsnyder benpsnyder changed the title feat(linter): support eslint.config.cjs with flat config feat(linter): support eslint.config.cjs and eslint.config.mjs with flat config Jun 22, 2024
@benpsnyder benpsnyder force-pushed the feat/support-cjs-flat-config-eslint branch from d9480e0 to 6444ef3 Compare June 22, 2024 19:24
@benpsnyder benpsnyder closed this Jun 22, 2024
@benpsnyder benpsnyder force-pushed the feat/support-cjs-flat-config-eslint branch from 6444ef3 to 963f753 Compare June 22, 2024 19:36
@benpsnyder benpsnyder reopened this Jun 22, 2024
@benpsnyder benpsnyder changed the title feat(linter): support eslint.config.cjs and eslint.config.mjs with flat config feat(linter): support eslint.config.cjs with flat config Jun 22, 2024
@benpsnyder benpsnyder changed the title feat(linter): support eslint.config.cjs with flat config feat(linter): support eslint.config.cjs and *.cjs extension with flat config Jun 22, 2024
@benpsnyder benpsnyder force-pushed the feat/support-cjs-flat-config-eslint branch from da8fb84 to 0c75d64 Compare June 22, 2024 19:53
@benpsnyder
Copy link
Copy Markdown
Contributor Author

benpsnyder commented Jun 22, 2024

@meeroslav my testing process was to build locally using nx run eslint:build then I used rsync on my node_modules rsync -av --delete /Volumes/SnyderDev/@benpsnyder/nx/build/packages/eslint/src/ /Volumes/SnyderDev/snyder/snyder-apps/node_modules/@nx/eslint/src/

I successfully was able to use my eslint.config.cjs file 👯

@benpsnyder
Copy link
Copy Markdown
Contributor Author

benpsnyder commented Jul 3, 2024

@meeroslav kindly include for v19.4.1 .. this PR should be ready to go

@AgentEnder AgentEnder merged commit 81fe132 into nrwl:master Jul 8, 2024
FrozenPandaz pushed a commit that referenced this pull request Jul 8, 2024
@benpsnyder @FrozenPandaz
feat(linter): support eslint.config.cjs and *.cjs extension with …
8462387 
…flat config (#26637)

(cherry picked from commit 81fe132)
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 14, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AgentEnder AgentEnder AgentEnder approved these changes

@meeroslav meeroslav Awaiting requested review from meeroslav meeroslav was automatically assigned from nrwl/nx-linter-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support .cjs file extension when using eslint flat config

2 participants

@benpsnyder @AgentEnder