feat(nextjs): add experimental-build-mode option to support compile only#26465
Merged
ndcunningham merged 4 commits intonrwl:masterfrom Jun 26, 2024
Merged
feat(nextjs): add experimental-build-mode option to support compile only#26465ndcunningham merged 4 commits intonrwl:masterfrom
ndcunningham merged 4 commits intonrwl:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 97ef37e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
Thanks for opening this PR. This has been high on my wishlist for quite some time |
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior - wrapper echo's its contents - wrapper doesn't exit properly - wrapper has LF line endings ## Expected Behavior - wrapper is silent - wrapper exits early - wrapper has CRLF endings ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes nrwl#26254
6eeca05 to
484d1a5
Compare
dfr-exnaton
commented
Jun 10, 2024
| "experimentalBuildMode": { | ||
| "type": "string", | ||
| "description": "Change the build mode.", | ||
| "enum": ["compile", "generate"] |
Contributor
Author
There was a problem hiding this comment.
There is some confusion w.r.t. to the default option. The documentation shows it as available, if you pass it the CLI will complain though.
Contributor
Author
|
@ndcunningham could you have a quick look? This is a super small and non-intrusive change making lives for users of nextjs in a 12-factor setting much easier... thanks a lot! |
meeroslav
pushed a commit
that referenced
this pull request
Jun 27, 2024
…nly (#26465) ## Current Behavior The nextjs build executor does not support all build flags such as `--experimental-build-mode` (see https://nextjs.org/docs/app/api-reference/next-cli#build). ## Expected Behavior For certain deployment models (e.g. mult-environment builds), it is helpful to only compile but not generate pages at build time. See vercel/next.js#46544 for a discussion. --------- Co-authored-by: Emily Xiong <xiongemi@gmail.com> Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com>
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The nextjs build executor does not support all build flags such as
--experimental-build-mode(see https://nextjs.org/docs/app/api-reference/next-cli#build).Expected Behavior
For certain deployment models (e.g. mult-environment builds), it is helpful to only compile but not generate pages at build time. See vercel/next.js#46544 for a discussion.