fix(js): node executor now correctly kills tasks when exiting#19219
Merged
jaysoo merged 1 commit intonrwl:masterfrom Jun 28, 2024
Merged
fix(js): node executor now correctly kills tasks when exiting#19219jaysoo merged 1 commit intonrwl:masterfrom
jaysoo merged 1 commit intonrwl:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
I've been looking for this as well! |
jaysoo
approved these changes
Jun 28, 2024
Contributor
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e4678eb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Previously, the node executor od @nx/js did not kill spawned processes due to not awaiting finishing of killing and infinite loop. This fix allows for seemless running nx in docker containers with support for signals
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the node executor od @nx/js did not kill spawned processes due to not awaiting finishing of killing and infinite loop.
This fix allows for seemless running nx in docker containers with support for signals
Current Behavior
When killing nx running
@nx/js:node, child processes are not killedExpected Behavior
Child processes should be killed