fix: log if npm deprecate does not match any version#7474
Merged
wraithgar merged 4 commits intonpm:latestfrom May 6, 2024
Merged
fix: log if npm deprecate does not match any version#7474wraithgar merged 4 commits intonpm:latestfrom
npm deprecate does not match any version#7474wraithgar merged 4 commits intonpm:latestfrom
Conversation
npm deprecate does not match any versionnpm deprecate does not match any version
Member
|
We have a test that covers this code path cli/test/lib/commands/deprecate.js Line 157 in e39d422 You can see in another test how we can import logs from the npm test object Line 233 in e39d422 And then we can assert that this logging message happened Line 241 in e39d422 |
Contributor
Author
|
Always pays to test even for small changes 😃 |
wraithgar
approved these changes
May 6, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's try again. If the package specification does not match any existing version, a verbose message is added to the log.
References
Ref #7472
Closes #7180