fix: send proper otp token on web auth#7545
Merged
Conversation
hashtagchris
approved these changes
May 20, 2024
Contributor
hashtagchris
left a comment
There was a problem hiding this comment.
LGTM. Was this a recent regression?
Member
Author
|
@hashtagchris yes three weeks ago a lot of this otp code was consolidated and this one field was missed. |
Merged
Collaborator
|
no statistically significant performance changes detected timing results
|
This comment was marked as spam.
This comment was marked as spam.
2 tasks
|
can confirm "otp" fails because ["otp" with value "[object Object]" fails to match the required pattern: /^\d+$/, "otp" length must be 64 characters long] is still a bug on 10.8.0 as of today, downgrading with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.