Skip to content

fix(documentation): Add notes about Scope vs Interceptor matchHeader calls#2382

Merged
gr2m merged 2 commits intonock:mainfrom
DavidTanner:ISSUE-2381/updateMatchHeaderReadme
Jul 19, 2022
Merged

fix(documentation): Add notes about Scope vs Interceptor matchHeader calls#2382
gr2m merged 2 commits intonock:mainfrom
DavidTanner:ISSUE-2381/updateMatchHeaderReadme

Conversation

@DavidTanner
Copy link
Copy Markdown
Contributor

@DavidTanner DavidTanner commented Jul 18, 2022

Closes #2381
The README doesn't currently specify the difference between calling matchHeader on a Scope vs Interceptor. Following the example led to issues where the header value was overridden by subsequent calls to matchHeader on the Scope.

Copy link
Copy Markdown
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks a lot!

@gr2m gr2m merged commit d9bab65 into nock:main Jul 19, 2022
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 13.2.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple matchHeader causes "No match for request"

2 participants