Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nock/nock
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v11.4.0
Choose a base ref
...
head repository: nock/nock
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v11.5.0
Choose a head ref
  • 6 commits
  • 6 files changed
  • 3 contributors

Commits on Oct 15, 2019

  1. refactor(router): pass socket to response constructor. (#1743)

    Passing the socket from the request to the `IncomingMessage` is what
    happens in native Node. Using a dummy `EventEmitter` then tacking the
    socket onto the response later is kludge from historical tech-debt that
    can now safely be cleaned up.
    mastermatt authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    d687179 View commit details
    Browse the repository at this point in the history
  2. chore: limit published files (#1745)

    By default, NPM will pack and publish all files in the directory.
    For us, that was 50+ files including lint configs, Github templates,
    RFCs, examples, etc.
    This change limits the files to just those used by consumers when in the
    context of a dependency. Plus what NPM always includes: README, LICENSE,
    and CHANGELOG.
    mastermatt authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    69976a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2019

  1. Configuration menu
    Copy the full SHA
    2d611db View commit details
    Browse the repository at this point in the history
  2. refactor(test_allow_unmocked_https): Avoid a hardcoded port (#1751)

    This test was flaky on my machine.
    
    I’ve also refactored to use async and the tap assertions a little more cleanly.
    paulmelnikow authored Oct 19, 2019
    Configuration menu
    Copy the full SHA
    be011ea View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. refactor: Rewrite a gnarly nested loop (#1755)

    This also renames the `scopes` property to `interceptors`, which is more appropriate since it holds instances of `Interceptor`.
    paulmelnikow authored Oct 22, 2019
    Configuration menu
    Copy the full SHA
    7a568dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7f9f13 View commit details
    Browse the repository at this point in the history
Loading