feat: Throw an error on invalid truthy reply status codes (#1571)

mastermatt · paulmelnikow · commit de525a1c1049 · 2019-05-28T10:35:44.000-04:00
diff --git a/lib/interceptor.js b/lib/interceptor.js
@@ -90,7 +90,7 @@ Interceptor.prototype.reply = function reply(statusCode, body, rawHeaders) {
     this.statusCode = null
     this.fullReplyFunction = statusCode
   } else {
-    if (statusCode && !Number.isInteger(statusCode)) {
+    if (statusCode !== undefined && !Number.isInteger(statusCode)) {
       throw new Error(`Invalid ${typeof statusCode} value for status code`)
     }
 
diff --git a/tests/test_reply_body.js b/tests/test_reply_body.js
@@ -158,3 +158,16 @@ test('reply with missing status code defaults to 200', async t => {
   t.equal(body, '')
   scope.done()
 })
+
+test('reply with invalid status code throws', t => {
+  const scope = nock('http://localhost').get('/')
+
+  t.throws(() => scope.reply('200'), {
+    message: 'Invalid string value for status code',
+  })
+  t.throws(() => scope.reply(false), {
+    message: 'Invalid boolean value for status code',
+  })
+
+  t.end()
+})

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ Interceptor.prototype.reply = function reply(statusCode, body, rawHeaders) {`
`90`	`90`	`this.statusCode = null`
`91`	`91`	`this.fullReplyFunction = statusCode`
`92`	`92`	`} else {`
`93`		`- if (statusCode && !Number.isInteger(statusCode)) {`
	`93`	`+ if (statusCode !== undefined && !Number.isInteger(statusCode)) {`
`94`	`94`	throw new Error(`Invalid ${typeof statusCode} value for status code`)
`95`	`95`	`}`
`96`	`96`