fix: alias connection to socket. (#1590)

mastermatt · paulmelnikow · gr2m · commit 659bf018977f · 2019-06-20T12:32:27.000-07:00
`ClientRequest.connection` is an alias for `ClientRequest.socket`. https://nodejs.org/api/http.html#http_request_socket https://github.com/nodejs/node/blob/master/lib/_http_client.js#L640-L641 `IncomingMessage.connection` is an alias for `IncomingMessage.socket`. https://github.com/nodejs/node/blob/master/lib/_http_incoming.js#L44-L45 Co-Authored-By: Paul Melnikow <github@paulmelnikow.com>
diff --git a/lib/request_overrider.js b/lib/request_overrider.js
@@ -89,18 +89,22 @@ function RequestOverrider(req, options, interceptors, remove, cb) {
     )
   }
 
-  if (!req.connection) {
-    req.connection = new EventEmitter()
-  }
-
   req.path = options.path
   req.method = options.method
 
   options.getHeader = function(name) {
     return getHeader(req, name)
   }
 
-  req.socket = response.socket = Socket({ proto: options.proto })
+  // ClientRequest.connection is an alias for ClientRequest.socket
+  // https://nodejs.org/api/http.html#http_request_socket
+  // https://github.com/nodejs/node/blob/b0f75818f39ed4e6bd80eb7c4010c1daf5823ef7/lib/_http_client.js#L640-L641
+  // IncomingMessage.connection is an alias for IncomingMessage.socket
+  // https://github.com/nodejs/node/blob/b0f75818f39ed4e6bd80eb7c4010c1daf5823ef7/lib/_http_incoming.js#L44-L45
+  // The same Socket is shared between the request and response to mimic native behavior.
+  req.socket = req.connection = response.socket = response.connection = Socket({
+    proto: options.proto,
+  })
 
   req.write = function(buffer, encoding, callback) {
     debug('write', arguments)
diff --git a/tests/test_request_overrider.js b/tests/test_request_overrider.js
@@ -329,6 +329,21 @@ test('request emits socket', t => {
   })
 })
 
+test('socket is shared and aliased correctly', t => {
+  nock('http://example.test')
+    .get('/')
+    .reply()
+
+  const req = http.get('http://example.test')
+
+  req.once('response', res => {
+    t.is(req.socket, req.connection)
+    t.is(req.socket, res.socket)
+    t.is(res.socket, res.connection)
+    t.end()
+  })
+})
+
 test('socket emits connect and secureConnect', t => {
   t.plan(3)
 
