feat(requestoverrider): Add method property to mocked requests (#1561)

mrijke · paulmelnikow · commit 4857ae5b4b65 · 2019-05-21T08:29:47.000-04:00
diff --git a/lib/request_overrider.js b/lib/request_overrider.js
@@ -94,6 +94,7 @@ function RequestOverrider(req, options, interceptors, remove, cb) {
   }
 
   req.path = options.path
+  req.method = options.method
 
   options.getHeader = function(name) {
     return getHeader(req, name)
diff --git a/tests/test_request_overrider.js b/tests/test_request_overrider.js
@@ -393,3 +393,24 @@ test('should throw expected error when creating request with missing options', t
   })
   t.end()
 })
+
+// https://github.com/nock/nock/issues/1558
+test("mocked requests have 'method' property", t => {
+  const scope = nock('http://example.test')
+    .get('/somepath')
+    .reply(200, {})
+
+  const req = http.request({
+    host: 'example.test',
+    path: '/somepath',
+    method: 'GET',
+    port: 80,
+  })
+  t.equal(req.method, 'GET')
+  req.on('response', function(res) {
+    t.equal(res.req.method, 'GET')
+    scope.done()
+    t.end()
+  })
+  req.end()
+})

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,7 @@ function RequestOverrider(req, options, interceptors, remove, cb) {`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`req.path = options.path`
	`97`	`+ req.method = options.method`
`97`	`98`
`98`	`99`	`options.getHeader = function(name) {`
`99`	`100`	`return getHeader(req, name)`