feat(core): middleware runs once for matching route#9809
Merged
kamilmysliwiec merged 3 commits intonestjs:10.0.0from Jun 12, 2023
Merged
feat(core): middleware runs once for matching route#9809kamilmysliwiec merged 3 commits intonestjs:10.0.0from
kamilmysliwiec merged 3 commits intonestjs:10.0.0from
Conversation
Pull Request Test Coverage Report for Build c179baca-5af3-4693-b615-af5c35fafab1
💛 - Coveralls |
9f50226 to
3281696
Compare
micalevisk
reviewed
Jun 24, 2022
micalevisk
reviewed
Jun 24, 2022
micalevisk
approved these changes
Jun 25, 2022
Tony133
suggested changes
Jun 26, 2022
Contributor
Tony133
left a comment
There was a problem hiding this comment.
A little convention/syntax fix while otherwise fine, but let's see what Kamil thinks.
Co-authored-by: Antonio T. as Tony <Tony133@users.noreply.github.com>
Tony133
approved these changes
Jun 26, 2022
hebertcisco
approved these changes
Jun 28, 2022
5 tasks
12 tasks
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, routes that has dynamic params can trigger a middleware multiple times for a single request if matches another static route inside the controller.
Issue Number: #1628
What is the new behavior?
Routes will only trigger the middleware for the exact path match.
Does this PR introduce a breaking change?
Other information