feat(common): Add error chaining support to http exception#9705
Merged
kamilmysliwiec merged 2 commits intonestjs:9.0.0from Jun 15, 2022
Merged
feat(common): Add error chaining support to http exception#9705kamilmysliwiec merged 2 commits intonestjs:9.0.0from
kamilmysliwiec merged 2 commits intonestjs:9.0.0from
Conversation
Adds the ability to configure the cause of an error when passing an error object to http exception. - https://nodejs.org/en/blog/release/v16.9.0/#error-cause - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Error#rethrowing_an_error_with_a_cause - microsoft/TypeScript#45167
Pull Request Test Coverage Report for Build 512b089e-b006-4e11-805a-1f5a3c4a7e57
💛 - Coveralls |
thiagomini
reviewed
Jun 1, 2022
Member
|
lgtm |
12 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to configure the cause of an error when passing an error object to http exception.
I would love to see HTTP Exception change over time to be more flexible, such as having both a custom message and a cause, but for now this fits my needs.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
You can't set the
causeof an error object.Issue Number: N/A
What is the new behavior?
It is now possible to set the cause of an HTTP Exception based error.
Does this PR introduce a breaking change?
Other information
Documentation