fix(microservices): allow postfixId on KafkaOptions to be an empty string#9681
Merged
kamilmysliwiec merged 2 commits intonestjs:9.0.0from Jun 15, 2022
Merged
fix(microservices): allow postfixId on KafkaOptions to be an empty string#9681kamilmysliwiec merged 2 commits intonestjs:9.0.0from
postfixId on KafkaOptions to be an empty string#9681kamilmysliwiec merged 2 commits intonestjs:9.0.0from
Conversation
micalevisk
commented
May 28, 2022
| transport?: Transport.KAFKA; | ||
| options?: { | ||
| /** | ||
| * Defaults to `"-server"` on server side and `"-client"` on client side. |
Member
Author
There was a problem hiding this comment.
we can't use @default tag here because KafkaOptions['options'] is being used by both client and server
Pull Request Test Coverage Report for Build 2a657836-8071-4fbb-bae6-3e30bf574ef4
💛 - Coveralls |
Tony133
approved these changes
May 28, 2022
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: closes #9677
What is the new behavior?
empty strings on
postfixIdoption onKafkaServerandKafkaClient'sconstructorare allowed nowDoes this PR introduce a breaking change?
as we're changing the behavior of a public API (
ClientsModule.register)