Skip to content

feat(common,core): make HttpServer#applyVersionFilter mandatory#9591

Merged
kamilmysliwiec merged 2 commits intonestjs:9.0.0from
micalevisk:make-applyVersionFilter-mandatory
May 18, 2022
Merged

feat(common,core): make HttpServer#applyVersionFilter mandatory#9591
kamilmysliwiec merged 2 commits intonestjs:9.0.0from
micalevisk:make-applyVersionFilter-mandatory

Conversation

@micalevisk
Copy link
Copy Markdown
Member

@micalevisk micalevisk commented May 17, 2022 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

@micalevisk micalevisk force-pushed the make-applyVersionFilter-mandatory branch from 0356397 to ff252a8 Compare May 17, 2022 14:56
@coveralls
Copy link
Copy Markdown

coveralls commented May 17, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 6f881a0e-7ff0-484c-97bb-06939d13de5c

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 94.109%
Totals Coverage Status
Change from base Build dc6b1e43-1d4d-4009-8b53-5ee2fd59bb11: 0.002%
Covered Lines: 5735
Relevant Lines: 6094
💛 - Coveralls

@micalevisk micalevisk marked this pull request as draft May 17, 2022 17:09
@micalevisk micalevisk force-pushed the make-applyVersionFilter-mandatory branch from ff252a8 to 696672e Compare May 18, 2022 00:16
@micalevisk micalevisk marked this pull request as ready for review May 18, 2022 00:16
micalevisk
micalevisk commented May 18, 2022
View reviewed changes
Comment thread packages/core/test/router/router-explorer.spec.ts
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 9.0.0 May 18, 2022 07:27
@kamilmysliwiec kamilmysliwiec merged commit 34d09c0 into nestjs:9.0.0 May 18, 2022
@micalevisk micalevisk deleted the make-applyVersionFilter-mandatory branch May 18, 2022 11:23
@kamilmysliwiec kamilmysliwiec added this to the 9.0.0 milestone May 20, 2022
@kamilmysliwiec kamilmysliwiec mentioned this pull request May 20, 2022
Merged
12 tasks
@micalevisk micalevisk changed the title feat(common,core)!: make HttpServer#applyVersionFilter mandatory feat(common,core): make HttpServer#applyVersionFilter mandatory May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

scope: core scope: platform type: enhancement 🐺

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@micalevisk @coveralls @kamilmysliwiec