fix(microservices): send rmq nack without matching message handler#12974
Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom Feb 7, 2024
toxol:rmq-nack-when-no-message-handler
Merged
fix(microservices): send rmq nack without matching message handler#12974kamilmysliwiec merged 1 commit intonestjs:masterfrom toxol:rmq-nack-when-no-message-handler
kamilmysliwiec merged 1 commit intonestjs:masterfrom
toxol:rmq-nack-when-no-message-handler
Conversation
Pull Request Test Coverage Report for Build 94e229fb-3dc9-4b6c-963d-297f38640fd3
💛 - Coveralls |
benjGam
approved these changes
Dec 31, 2023
This was referenced Jun 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
Same problem as descibed in issue 11641 but for messages (not events).
With RMQ Options:
When you send a message (using
client.send()) with an unknown pattern, the server does not send an acknowledgment. The message remains unacknowledged. Application reaches prefetch count and freezes.Minimum reproduction code - https://github.com/toxol/nest-rmq-nack
What is the new behavior?
When RMQ server receives a message for which there is no handler, it will send a negative acknowledgment without retrying.
Does this PR introduce a breaking change?
Other information