fix(platform-ws): URL parsing error handled#12385
Merged
kamilmysliwiec merged 2 commits intonestjs:masterfrom Oct 5, 2023
Merged
fix(platform-ws): URL parsing error handled#12385kamilmysliwiec merged 2 commits intonestjs:masterfrom
kamilmysliwiec merged 2 commits intonestjs:masterfrom
Conversation
Invalid URL TypeError handled with a try-catch block fixes nestjs#12381
Pull Request Test Coverage Report for Build b02a4722-7eed-42bf-9574-6e366bc9c115
💛 - Coveralls |
jmcdo29
reviewed
Sep 13, 2023
Member
jmcdo29
left a comment
There was a problem hiding this comment.
LGTM. How can we make sure this change is tested?
Contributor
Author
Added HTTP head to the socket end message for message parsing. I did not manage to create sample project that uses my forked package. Tried to use gitpkg website but keep getting the module @nestjs/platform-ws is not found. |
15 tasks
Maxwell0010
approved these changes
Sep 16, 2023
jmcdo29
approved these changes
Sep 17, 2023
Tony133
approved these changes
Sep 18, 2023
rubiin
approved these changes
Sep 19, 2023
Contributor
Author
|
@kamilmysliwiec I cannot merge this, who else needs to approve? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid URL TypeError handled with a try-catch block
fixes #12381
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #12381
What is the new behavior?
In case of invalid URL socket is closed with an error message.
Does this PR introduce a breaking change?
Other information