fix(common): loosen http exception cause type#11673
Merged
kamilmysliwiec merged 1 commit intonestjs:masterfrom Jun 12, 2023
Merged
fix(common): loosen http exception cause type#11673kamilmysliwiec merged 1 commit intonestjs:masterfrom
kamilmysliwiec merged 1 commit intonestjs:masterfrom
Conversation
1 task
kamilmysliwiec
approved these changes
May 29, 2023
kamilmysliwiec
approved these changes
May 29, 2023
rubiin
approved these changes
Jun 2, 2023
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Docs have been added / updated (N/A)PR Type
What is the current behavior?
Issue Number: #11665
What is the new behavior?
Loose
HttpExceptionOptions.causetype fromErrortounknown.Does this PR introduce a breaking change?
Other information
Per MDN documentation it seems this property can by of any type (given you can throw anything in JavaScript), so internal conditional logic seems unnecessary.