Skip to content

[TreeView] Fix hydration error#15002

Merged
flaviendelangle merged 2 commits intomui:masterfrom
flaviendelangle:hydration-tree-view
Oct 17, 2024
Merged

[TreeView] Fix hydration error#15002
flaviendelangle merged 2 commits intomui:masterfrom
flaviendelangle:hydration-tree-view

Conversation

@flaviendelangle
Copy link
Copy Markdown
Member

@flaviendelangle flaviendelangle commented Oct 17, 2024 •
edited
Loading

Fixes #14980
Extracted from #14210

Only sets the default id attribute after the hydration, like useId does

@flaviendelangle flaviendelangle self-assigned this Oct 17, 2024
@flaviendelangle flaviendelangle marked this pull request as draft October 17, 2024 09:02
@flaviendelangle flaviendelangle added type: regression A bug, but worse, it used to behave as expected. scope: tree view Changes related to the tree view. This includes TreeView, TreeItem. labels Oct 17, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Oct 17, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15002--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 68456d2

@flaviendelangle flaviendelangle marked this pull request as ready for review October 17, 2024 09:09
@flaviendelangle flaviendelangle mentioned this pull request Oct 17, 2024
Merged
LukasTy
LukasTy approved these changes Oct 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Comment thread packages/x-tree-view/src/internals/corePlugins/useTreeViewId/useTreeViewId.ts Outdated
@flaviendelangle @LukasTy
Update packages/x-tree-view/src/internals/corePlugins/useTreeViewId/u…
68456d2 
…seTreeViewId.ts

Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@flaviendelangle flaviendelangle merged commit 7b8d976 into mui:master Oct 17, 2024
@flaviendelangle flaviendelangle deleted the hydration-tree-view branch October 17, 2024 13:53
This was referenced Nov 8, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasTy LukasTy LukasTy approved these changes

@noraleonte noraleonte Awaiting requested review from noraleonte

@michelengelen michelengelen Awaiting requested review from michelengelen

Assignees

@flaviendelangle flaviendelangle

Labels

scope: tree view Changes related to the tree view. This includes TreeView, TreeItem. type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tree view] Hydration error from 7.19.0 onwards

3 participants

@flaviendelangle @mui-bot @LukasTy