Skip to content

[DataGridPro] Fix indeterminate checkbox state for server-side data#14956

Merged
MBilalShafi merged 1 commit intomui:masterfrom
MBilalShafi:indeterminate
Oct 16, 2024
Merged

[DataGridPro] Fix indeterminate checkbox state for server-side data#14956
MBilalShafi merged 1 commit intomui:masterfrom
MBilalShafi:indeterminate

Conversation

@MBilalShafi
Copy link
Copy Markdown
Member

@MBilalShafi MBilalShafi commented Oct 14, 2024

@MBilalShafi MBilalShafi added type: bug It doesn't behave as expected. scope: data grid Changes related to the data grid. feature: Selection Related to the data grid Selection feature labels Oct 14, 2024
@MBilalShafi MBilalShafi changed the title [DataGridPro] Fix indeterminate checkbox state for server-side tree data [DataGridPro] Fix indeterminate checkbox state for server-side data Oct 14, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Oct 14, 2024

Deploy preview: https://deploy-preview-14956--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7df0782

@MBilalShafi MBilalShafi requested a review from a team October 16, 2024 13:30
@MBilalShafi MBilalShafi marked this pull request as ready for review October 16, 2024 13:30
@arminmeh
Copy link
Copy Markdown
Contributor

would be good to add a test for this so that we don't get regression if we do some refactoring in the future

@MBilalShafi MBilalShafi merged commit aa40880 into mui:master Oct 16, 2024
@MBilalShafi
Copy link
Copy Markdown
Member Author

MBilalShafi commented Oct 16, 2024

would be good to add a test for this so that we don't get regression if we do some refactoring in the future

This specific use-case was trivial enough in my opinion to add a test case for, however I'll try to add one in a follow up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: Selection Related to the data grid Selection feature scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[data grid] Server tree data checkboxSelection style init

3 participants