Skip to content

[pickers] Fix regression on PickerValidDate#14896

Merged
flaviendelangle merged 2 commits intomui:masterfrom
flaviendelangle:typo-picker-valid-date
Oct 9, 2024
Merged

[pickers] Fix regression on PickerValidDate#14896
flaviendelangle merged 2 commits intomui:masterfrom
flaviendelangle:typo-picker-valid-date

Conversation

@flaviendelangle
Copy link
Copy Markdown
Member

@flaviendelangle flaviendelangle commented Oct 9, 2024 •
edited
Loading

Fix #14895

@flaviendelangle flaviendelangle changed the title [pickers] Fix regression on `PickerValidDate [pickers] Fix regression on PickerValidDate Oct 9, 2024
@flaviendelangle flaviendelangle self-assigned this Oct 9, 2024
@flaviendelangle flaviendelangle added typescript type: regression A bug, but worse, it used to behave as expected. scope: pickers Changes related to the date/time pickers. labels Oct 9, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Oct 9, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14896--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0c6c7b8

@flaviendelangle flaviendelangle mentioned this pull request Oct 9, 2024
Closed
flaviendelangle
flaviendelangle commented Oct 9, 2024
View reviewed changes
Comment thread packages/x-date-pickers-pro/src/DateTimeRangePicker/DateTimeRangePickerToolbar.tsx
],
}) as DateTimeRangePickerStartOrEndToolbarComponent;

type DateTimeRangePickerToolbarComponent = (<TDate extends PickerValidDate>(
Copy link
Copy Markdown
Member Author

@flaviendelangle flaviendelangle Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why, but without it the type gets inline in the bundle and we end up with the following:

image

Copy link
Copy Markdown
Member

@michelengelen michelengelen Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷🏼

@flaviendelangle flaviendelangle marked this pull request as ready for review October 9, 2024 12:38
michelengelen
michelengelen reviewed Oct 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

Comment thread packages/x-date-pickers-pro/src/DateTimeRangePicker/DateTimeRangePickerToolbar.tsx
],
}) as DateTimeRangePickerStartOrEndToolbarComponent;

type DateTimeRangePickerToolbarComponent = (<TDate extends PickerValidDate>(
Copy link
Copy Markdown
Member

@michelengelen michelengelen Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷🏼

LukasTy
LukasTy approved these changes Oct 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍
Other cases would result in the same output if the as casting is removed. 🙈
I.e. DatePickerToolbar.
Ideally—it would be nice to automate the avoidance of such output. 😆

@flaviendelangle
Copy link
Copy Markdown
Member Author

flaviendelangle commented Oct 9, 2024

Ideally—it would be nice to automate the avoidance of such output.

A dirty solution would be to look automatically for import('lodash') and equivalent in the build (outside of the adapters)

@LukasTy
Copy link
Copy Markdown
Member

LukasTy commented Oct 9, 2024

A dirty solution would be to look automatically for import('lodash') and equivalent in the build (outside of the adapters)

Yeah, my only idea as well. 🤔
But, I'd say that we could leave this effort for when and if we encounter the same problem. 👍 🙈

@flaviendelangle flaviendelangle merged commit 59a9bef into mui:master Oct 9, 2024
@flaviendelangle flaviendelangle deleted the typo-picker-valid-date branch October 9, 2024 14:01
@jcrang jcrang mentioned this pull request Oct 11, 2024
Closed
@flaviendelangle flaviendelangle mentioned this pull request Oct 11, 2024
Merged
@DMPatod DMPatod mentioned this pull request Nov 2, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Nov 5, 2024
Merged
This was referenced Nov 8, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michelengelen michelengelen michelengelen left review comments

@LukasTy LukasTy LukasTy approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels

scope: pickers Changes related to the date/time pickers. type: regression A bug, but worse, it used to behave as expected. typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pickers] Cannot compile in TypeScript with skipLibCheck: false

4 participants

@flaviendelangle @mui-bot @LukasTy @michelengelen