Skip to content

[docs] Add custom columns panel demo#14825

Merged
cherniavskii merged 6 commits intomui:masterfrom
cherniavskii:custom-columns-panel
Oct 8, 2024
Merged

[docs] Add custom columns panel demo#14825
cherniavskii merged 6 commits intomui:masterfrom
cherniavskii:custom-columns-panel

Conversation

@cherniavskii
Copy link
Copy Markdown
Member

@cherniavskii cherniavskii commented Oct 4, 2024

@cherniavskii cherniavskii added docs Improvements or additions to the documentation. scope: data grid Changes related to the data grid. customization: logic Logic customizability. feature: Column groups Related to the data grid Column groups feature labels Oct 4, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Oct 4, 2024

@cherniavskii cherniavskii marked this pull request as ready for review October 7, 2024 21:05
@cherniavskii cherniavskii requested review from a team and joserodolfofreitas October 7, 2024 21:05
Copy link
Copy Markdown
Member

@kenanyusuf kenanyusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one minor styling suggestion to increase the indentation of nested items.

label={group.headerName ?? group.groupId}
onChange={(_, newValue) => toggleColumnGroup(newValue)}
/>
<Box sx={{ pl: 1 }}>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Box sx={{ pl: 1 }}>
<Box sx={{ pl: 3.5 }}>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customization: logic Logic customizability. docs Improvements or additions to the documentation. feature: Column groups Related to the data grid Column groups feature feature: Column visibility scope: data grid Changes related to the data grid.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants