[docs] Divide charts tooltip and highlighting pages#14824
Merged
JCQuintas merged 8 commits intomui:masterfrom Oct 8, 2024
Merged
[docs] Divide charts tooltip and highlighting pages#14824JCQuintas merged 8 commits intomui:masterfrom
tooltip and highlighting pages#14824JCQuintas merged 8 commits intomui:masterfrom
Conversation
CodSpeed Performance ReportMerging #14824 will not alter performanceComparing Summary
|
mapache-salvaje
approved these changes
Oct 7, 2024
Contributor
mapache-salvaje
left a comment
There was a problem hiding this comment.
I would like to do line-by-line reviews of both docs in the near future but this looks good for now. Good call on separating them 👍
LukasTy
reviewed
Oct 8, 2024
Member
LukasTy
left a comment
There was a problem hiding this comment.
Great work. 👍
Cleaner result. 👌
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com> Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
LukasTy
approved these changes
Oct 8, 2024
This was referenced Nov 8, 2024
| * Default is set to 'band' in the bar direction. | ||
| * Depends on `layout` prop. | ||
| * @see See {@link https://mui.com/x/react-charts/tooltip/#highlights highlight docs} for more details. | ||
| * @see See {@link https://mui.com/x/react-charts/highlighting highlighting docs} for more details. |
Member
There was a problem hiding this comment.
Suggested change
| * @see See {@link https://mui.com/x/react-charts/highlighting highlighting docs} for more details. | |
| * @see See {@link https://mui.com/x/react-charts/highlighting/ highlighting docs} for more details. |
Fixed in 23646d8
A side note, we will move to non-trailing URLs, at one point mui/mui-public#248.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
highlightsections fromtooltippagehighlightingpage for that aspect