[pickers] Stop using utils in locales#14505
Merged
flaviendelangle merged 4 commits intomui:masterfrom Sep 6, 2024
Merged
Conversation
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-14505--material-ui-x.netlify.app/ |
6d4b7ff to
6c5ee15
Compare
6c5ee15 to
fcb0c56
Compare
kealjones-wk
reviewed
Sep 5, 2024
d3581a8 to
14115d2
Compare
14115d2 to
87a1495
Compare
87a1495 to
7f999ee
Compare
LukasTy
reviewed
Sep 6, 2024
Member
LukasTy
left a comment
There was a problem hiding this comment.
Thank you for taking care of it! 🙏
The DX looks great. 👍
We are going to clean this up nicely on 8. 👌
bfa9928 to
01d8427
Compare
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
This was referenced Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13768
I need to avoid 2 type of breaking changes
valueandutils)formattedDateyet)So I'm handling both the old and the new format in each locale.
This is not clean code, but we can clean it easily during the alpha and the end result will be even better than before this PR.
New DX
In v7
In v8
Follow up
valueandutilsparams fromopenDatePickerDialogue,openTimePickerDialogueandclockLabelText